Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial/complete downscaling and update metrix dependency to 2.3.0 #66

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

colinepiloquet
Copy link
Member

@colinepiloquet colinepiloquet commented Aug 7, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) -> I will modify the documentation in the new read the docs ([Documentation] Add read the docs #67)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Structure update of the downscaling tutorial.

What is the current behavior?

The tutorial has an old structure and does not use released version of powsybl-metrix.

What is the new behavior (if this is a feature change)?
The initial/complete folders are removed and the version of metrix is updated to last released one 2.3.0.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Copy link
Member Author

@rolnico, can we talk about that when you have time? I don't know if it's a good idea but if you think it is, I will need help with the metrix part. I think we should update the version to have the latest release but I don't know how to adapt the code accordingly.

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet
Copy link
Member Author

Note: documentation should then also be updated.

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico force-pushed the remove_initial_complete_downscaling branch from 9f464fb to 622db6d Compare August 26, 2024 13:28
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet colinepiloquet changed the title [WIP] Remove initial/complete downscaling Remove initial/complete downscaling Aug 28, 2024
@colinepiloquet colinepiloquet marked this pull request as ready for review August 28, 2024 14:24
@colinepiloquet colinepiloquet requested a review from rolnico August 28, 2024 14:26
@colinepiloquet colinepiloquet changed the title Remove initial/complete downscaling Remove initial/complete downscaling and update metrix dependency to 2.3.0 Aug 28, 2024
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants