-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tomcat monitoring and generalize prometheus endpoint exposure #49
Conversation
fc31cec
to
120b320
Compare
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
120b320
to
bdeec8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this config is used not only by GridSuite, have you checked if adding "prometheus" in exposures and the dependencies micrometer-registry-prometheus
or spring-boot-actuator
aren't present spring-boot don't fail somewhere?
I verified that if the dependency micrometer-registry-prometheus is not added, the endpoint actuator/prometheus is not created as expected. There is no error. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Other informations
Will be release with powsybl/powsybl-ws-dependencies#37