Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tomcat monitoring and generalize prometheus endpoint exposure #49

Merged
merged 1 commit into from
May 13, 2024

Conversation

antoinebhs
Copy link
Collaborator

@antoinebhs antoinebhs commented Apr 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

What kind of change does this PR introduce?

  • Enable tomcat monitoring in our microservices.
  • Add the actuator/prometheus endpoint by default

Other informations
Will be release with powsybl/powsybl-ws-dependencies#37

@antoinebhs antoinebhs force-pushed the monitor-tomcat branch 2 times, most recently from fc31cec to 120b320 Compare April 23, 2024 11:20
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
Copy link
Member

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this config is used not only by GridSuite, have you checked if adding "prometheus" in exposures and the dependencies micrometer-registry-prometheus or spring-boot-actuator aren't present spring-boot don't fail somewhere?

This was referenced May 13, 2024
@antoinebhs
Copy link
Collaborator Author

As this config is used not only by GridSuite, have you checked if adding "prometheus" in exposures and the dependencies micrometer-registry-prometheus or spring-boot-actuator aren't present spring-boot don't fail somewhere?

I verified that if the dependency micrometer-registry-prometheus is not added, the endpoint actuator/prometheus is not created as expected. There is no error.

Tristan-WorkGH

This comment was marked as outdated.

@antoinebhs antoinebhs merged commit 1cd6e40 into main May 13, 2024
2 checks passed
@antoinebhs antoinebhs deleted the monitor-tomcat branch May 13, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants