adds a use_name parameter to the network explorer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay ids or names in the selection list and in the tabs content Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
flo-dup
reviewed
Jul 22, 2024
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
flo-dup
approved these changes
Jul 24, 2024
| self.use_name = use_name | ||
| self.display_attribute = 'name' if use_name else 'id' | ||
|
|
||
| self.vls = network.get_voltage_levels(attributes=['name']) |
There was a problem hiding this comment.
Just thinking about what could be done to display only specific kind of voltage levels, for a coming PR! To do something similar to the javaFX viewer where you could choose to display only voltage levels with specific equipments. That would mean having here a parameter, either a function (a voltage level provider) or a filter. We'll speak about it later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…display ids or names in the selection list and in the tabs content
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
adds a use_name parameter to the network_explorer. If set to True (the default) the explorer displays VLs names in the selection list and in the tabs widgets. When a name is not available, the Id is used.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: