Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves transition to a new VL (explorer's NAD tab) #35

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

no

What kind of change does this PR introduce?

improves visual transition to a new VL (explorer's NAD tab). More evident when it takes some time to compute the NAD for a new VL, the NAD tab view, with the current NAD, was reset to its original state before starting the computation.
This update keeps the pan&zoom levels and the position of the nodes for the current NAD, until the NAD for the new VL is ready.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi CBiasuzzi requested a review from flo-dup November 25, 2024 18:20
@flo-dup flo-dup merged commit 0b625c7 into main Nov 25, 2024
4 checks passed
@flo-dup flo-dup deleted the fix_explorer_nad_update branch November 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants