Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability to mix connection and disconnection in a single update #896

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Nov 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

We cannot in a single update mix connection and disconnection with no bus id for the disconnection.

What is the new behavior (if this is a feature change)?
We do not need anymore to specify a valid bus id for disconnection rows.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg requested a review from HugoKulesza November 27, 2024 09:20
Copy link

Copy link

@HugoKulesza HugoKulesza merged commit 6c4c84e into main Nov 28, 2024
8 checks passed
@HugoKulesza HugoKulesza deleted the mix_connect_disconnect_update branch November 28, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants