Dynamic simulation output variables supplier #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fsv input Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Lisrte
force-pushed
the
dynamic_output_variables
branch
from
482385b to
468d08c
Compare
HugoKulesza
reviewed
Dec 17, 2024
| @@ -37,4 +38,8 @@ def _get_all_curves(self) -> pd.DataFrame: | |||
| curve_name_lst = _pp.get_all_dynamic_curves_ids(self._handle) | |||
| df_curves = [self._get_curve(curve_name) | |||
| for curve_name in curve_name_lst] | |||
| return pd.concat(df_curves, axis=1) if df_curves else pd.DataFrame() | |||
| return pd.concat(df_curves, axis=1).ffill() if df_curves else pd.DataFrame() | |||
There was a problem hiding this comment.
By curiosity, why is .ffill needed here ?
There was a problem hiding this comment.
Curves are represented as a map of DoubleTimeSeries in Powsybl. When creating a DoubleTimeSeries for an individual curve, entries with the same value as the previous one are skipped. Thus when we concat curves series we have to fill forward in order to get these values back.
java/src/main/java/com/powsybl/dataframe/dynamic/OutputVariablesSeries.java
Outdated
Show resolved
Hide resolved
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
|
|
HugoKulesza
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
Dynamic simulation
CurveMappinghandle curve for dynamic models.What is the new behavior (if this is a feature change)?
CurveMappingis replaced withOutputVariableMappinghandling curves and final state values for equipment with or without dynamic models.Final state values results are provided by
SimulationResult.final_state_values.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Replace
CurveMapping::add_curveandCurveMapping::add_curvewithOutputVariableMapping::add_dynamic_model_curves.Other information:
Linked to the powsybl-dynawo PR 413
Without the PR, mapping with more than two curves will end with
pandas.errors.InvalidIndexError.