Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easy fix to allow selecting the root SD card volume #195

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

constambeys
Copy link
Contributor

No description provided.

@Xavron
Copy link

Xavron commented Jul 14, 2023

I'm confused. Did this not work on older Android versions? I see you changed some of the recent scoped storage code and Android 13 (or more correctly scoped storage on recent Android versions) done properly will not allow sd card root to be used.

I didn't test your changes here though and there's too many to know what the end result is which is why I'm asking what was going on here.

@Xavron
Copy link

Xavron commented Jul 14, 2023

Oh I see. You're trying to get ACTION_MANAGE_APP_ALL_FILES_ACCESS_PERMISSION into here. That's something Pieter will want to figure out. I'm not getting involved in this one lol. (Yeah, I know, already am a little :)P

Intent intent = new Intent(Settings.ACTION_MANAGE_APP_ALL_FILES_ACCESS_PERMISSION);

See here why its not allowed by the Play Store: https://support.google.com/googleplay/android-developer/answer/10467955?hl=en

A separate branch would probably be better. Google is very likely to deny approval of it for the app. And scoped storage is already implemented and working as its intended to work by Android. Of course if Pieter can get approval for it that would be cool. That's not my experience with it however lol.

@ppareit
Copy link
Owner

ppareit commented Jul 18, 2024

Seems like the perfect functionality for the f-droid version. The play-store version cannot have this.

@constambeys
Copy link
Contributor Author

constambeys commented Jul 18, 2024

Ok maybe is safer for the user to grant specific directory permissions !!!

@ppareit ppareit reopened this Jul 19, 2024
@ppareit
Copy link
Owner

ppareit commented Jul 19, 2024

I'll keep this open. I do like this modification. But only for f-droid version.

Your fix allows SwiFTP to be used in the spirit that it was written for. Access to all files on the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants