setup.py: Improve dependencies handling #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to create a I can do so in a follow-up PR though :) |
|
PS: The file is called |
4 tasks
nbraud
force-pushed
the
setup.py/dependencies
branch
from
b35272f to
1dd2b31
Compare
pathunstrom
approved these changes
Apr 1, 2019
5 tasks
bors bot
added a commit
to ppb/ppb-vector
that referenced
this pull request
Apr 4, 2019
141: setup.py improvements r=astronouth7303 a=nbraud Mostly the same thing as ppb/pursuedpybear#223 and ppb/pursuedpybear#224 : - [x] Rename `*-requirements.txt` to `requirements-*.txt` to follow PPB's convention. - [x] Extract runtime dependencies to `requirements.txt`. - [x] Move all metadata from `setup.py` to `setup.cfg`. - [x] Declare test dependencies in `setup.py`, integrate with `pytest`. - [x] Use `pyproject.toml` to explicitly declare that we are using `setuptools`. Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements.txt.This is necessary to be able to build CI environments as in CI: Cache dependencies in a container image nbraud/pursuedpybear#1.
requirements-tests.txt). Closes Add Test Dependencies to setup.py #222.setup.pyandpytestso callingsetup.py testdoes the right thing.