CI: Build custom containers with dependencies preinstalled #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can install all test dependencies (incl. pygame's build dependencies where necessary) in a container image, and cache those across builds. See https://medium.com/cirruslabs/introducing-container-builder-for-cirrus-ci-80b9234f007
This is nicer than detecting it at runtime, and can work with Windows
Also, get rid of the separate template.Dockerfile file
For some reason, Docker commands run in Powershell, and Powershell doesn't implement `&&`...
This is preparation for making docs and linting images.
nbraud
force-pushed
the
qa/cirrus-ci-containers
branch
from
3cae21a to
b3d023a
Compare
|
Rebased again to have |
pathunstrom
approved these changes
Apr 4, 2019
|
bors r+ r=pathunstrom |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2019
225: CI: Build custom containers with dependencies preinstalled r=nbraud a=nbraud Brings the CI times down to ~2s on Linux (from ~2m for envs with no `pygame` wheels), and to ~10s on Windows (from ~30s with `pygame` wheels). - [x] Build & use containers for tests under Linux and Windows. - [x] Build & use containers for the `docs` ~and `lint`~ tasks. - [x] Add a CI task to check the generated dockerfiles are up-to-date. I'd prefer not to commit generated files at all, but that was the simplest way to get going (Cirrus can just pull a Dockerfile from the repo) - [x] Give friendly names to the tasks using custom containers. Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
|
bors r- |
Canceled |
|
bors r=pathunstrom |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2019
225: CI: Build custom containers with dependencies preinstalled r=pathunstrom a=nbraud Brings the CI times down to ~2s on Linux (from ~2m for envs with no `pygame` wheels), and to ~10s on Windows (from ~30s with `pygame` wheels). - [x] Build & use containers for tests under Linux and Windows. - [x] Build & use containers for the `docs` ~and `lint`~ tasks. - [x] Add a CI task to check the generated dockerfiles are up-to-date. I'd prefer not to commit generated files at all, but that was the simplest way to get going (Cirrus can just pull a Dockerfile from the repo) - [x] Give friendly names to the tasks using custom containers. Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
Build succeeded
|
AstraLuma
added a commit
to AstraLuma/pursuedpybear
that referenced
this pull request
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the CI times down to ~2s on Linux (from ~2m for envs with no
pygamewheels), and to ~10s on Windows (from ~30s withpygamewheels).docsandtasks.lintI'd prefer not to commit generated files at all, but that was the simplest way to get going (Cirrus can just pull a Dockerfile from the repo)