Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document sprites #313

Merged
merged 2 commits into from
Jul 14, 2019
Merged

Document sprites #313

merged 2 commits into from
Jul 14, 2019

Conversation

AstraLuma
Copy link
Member

The sprite documentation was kinda empty.

Start fixing that.

@AstraLuma AstraLuma requested a review from a team as a code owner July 13, 2019 01:03
@AstraLuma AstraLuma mentioned this pull request Jul 13, 2019
Merged
pathunstrom
pathunstrom approved these changes Jul 14, 2019
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my intent to improve all of this documentation soon, but this is something in the mean time.

@pathunstrom
Copy link
Collaborator

bors r+

@pathunstrom pathunstrom added the bors Someone has bors r+ this PR label Jul 14, 2019
bors bot added a commit that referenced this pull request Jul 14, 2019
@bors @AstraLuma
Merge #313
9b3759a 
313: Document sprites r=pathunstrom a=astronouth7303

The sprite documentation was kinda empty.

Start fixing that.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2019

Build failed

  • Windows python:3.7-windowsservercore-1809

@AstraLuma
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Jul 14, 2019
@bors @AstraLuma
Merge #313
1600870 
313: Document sprites r=pathunstrom a=astronouth7303

The sprite documentation was kinda empty.

Start fixing that.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2019

Build failed

  • Linux python:3.7-slim
  • Windows python:3.6-windowsservercore-1809

bors bot added a commit that referenced this pull request Jul 14, 2019
@bors @AstraLuma
Merge #306
f5ebec0 
306: Revamp Assets r=pathunstrom a=astronouth7303

Totally revamp how PPB handles assets.

Depends on #313 because life was just easier that way.

Part of #147 

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@AstraLuma
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Jul 14, 2019
@bors @AstraLuma
Merge #313
af93334 
313: Document sprites r=pathunstrom a=astronouth7303

The sprite documentation was kinda empty.

Start fixing that.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2019

Build succeeded

  • docs
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • pep517
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit ecff29f into ppb:master Jul 14, 2019
@AstraLuma AstraLuma deleted the docs-sprites branch July 14, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
bors Someone has bors r+ this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @pathunstrom