Saften TargetSprite #458
Merged
Saften TargetSprite #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Crash on negative exponential_speed to prevent imaginary values. * Document effects of parameter value ranges. * Prevent zero division when max speed is negative and sprite is at target.
pathunstrom
reviewed
May 7, 2020
Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
|
Just want to ping this. I'm happy with what you've done here, just need it to be not a draft to get it in to the code base. |
pathunstrom
approved these changes
May 9, 2020
bors bot
added a commit
that referenced
this pull request
May 9, 2020
458: Saften TargetSprite r=pathunstrom a=serin-delaunay * Crash on negative exponential_speed to prevent imaginary values. * Document effects of parameter value ranges. * Prevent zero division when max speed is negative and sprite is at target. Tests still only cover the standard usage, not error conditions or negative speeds. Co-authored-by: Serin Delaunay <serin.delaunay@gmail.com>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests still only cover the standard usage, not error conditions or negative speeds.