Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ordinal direction unit vectors. #463

Merged
merged 2 commits into from
May 9, 2020

Conversation

pathunstrom
Copy link
Collaborator

Primary use case is to reduce the cognitive load in early lessons:

class OurSprite(Sprite):
    def on_update():
       self.facing = Left

@pathunstrom pathunstrom requested a review from a team as a code owner May 9, 2020 17:18
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, we have not been using ALL_CAPS for constants/flags/etc.

I'm also debating on if we want them available on the root? That kinda gets into making deliberate decisions about what's available from import ppb. (I thought there was an issue for it but i guess not.) I could go either way on ppb.Left vs ppb.directions.Left.

@pathunstrom
Copy link
Collaborator Author

I'll change the casing, figure ppb.directions.Left is probably a good place to start and be open to including it in the core name space if it's requested by teachers?

@AstraLuma
Copy link
Member

Good enough explanation.

Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors bors bot merged commit 51fe7a0 into ppb:master May 9, 2020
@pathunstrom pathunstrom deleted the ordinal-directions branch May 15, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants