Apply alpha blend modes and coloration to textures based on sprite data. #474
Conversation
There was a problem hiding this comment.
I still need to pull this and play around with it, but my first instinct is that the only thing here that concerns me is the standing concern about cluttering the Sprite attribute namespace. While I don't think opacity_mode is likely to be something end users are likely to make their own name, color could be.
I think this is the right place to do this sort of thing. We don't really have a way to store this transforms and cache them that I can see on the face of it, but I'm not sure we'll gain anything by doing so, either.
For now, I think we should discuss the names, and test this workflow in some different contexts. Can you provide some basic descriptions of how to use these features either in the PR or in comments?
ppb/systems/renderer.py
Outdated
| last_opacity: int = 255 | ||
| last_opacity_mode: str = 'blend' | ||
| last_color: Tuple[int, int, int] = (255, 255, 255) |
There was a problem hiding this comment.
Are these doing anything? I don't see them referenced elsewhere?
There was a problem hiding this comment.
this was part of an attempt I made to only call the SDL Set* functions when these changed, but I didn't get it working right and dropped it. I will clean this up.
ppb/systems/renderer.py
Outdated
| SDL_SetTextureAlphaMod, texture.inner, opacity, | ||
| _check_error=lambda rv: rv < 0 | ||
| ) | ||
| if opacity_mode == 'add': |
There was a problem hiding this comment.
Direct implementation is less of a big deal, but I'd definitely avoid magic strings if we can. Either make these class attributes, exported constants, or Flags. (Or enums, but want to check with some educators before we go too far down that route.)
|
Here's an example of where I use this in Seed Magic to do the particle effects: @classmethod
def spawn(cls, pos, color, heading=None, tsize=2.5):
s = cls.sparkles[cls.index]
cls.index = (cls.index + 1) % cls.size
if color == COLOR_BLACK:
s.opacity_mode = ppb.flag.BlendModeNone
s.opacity = 255
else:
s.opacity_mode = ppb.flag.BlendModeAdd
s.opacity = 128
s.color = color
s.position = pos
s.rotation = randint(0, 260)
s.size = 1.5
s.layer = 100
cls.t.tween(s, 'opacity', 0, 0.5, easing='linear')
cls.t.tween(s, 'size', tsize, 0.5, easing='linear')
delay(0.5, lambda: setattr(s, 'size', 0))
if heading:
cls.t.tween(s, 'position', heading, 0.5, easing='linear') |
|
One more question on this, is |
|
@pathunstrom Yes, right. Actually, with this, the generated sprites could be recolored on-demand, which might be useful. |
ppb/systems/renderer.py
Outdated
| opacity = getattr(game_object, 'opacity', 255) | ||
| opacity_mode = getattr(game_object, 'opacity_mode', flags.BlendModeBlend) | ||
| opacity_mode = OPACITY_MODES[opacity_mode] | ||
| color = getattr(game_object, 'color', (255, 255, 255)) |
There was a problem hiding this comment.
| color = getattr(game_object, 'color', (255, 255, 255)) | |
| color = getattr(game_object, 'tint', (255, 255, 255)) |
Regarding suggestion on discord.
ironfroggy
force-pushed
the
render-sprite-rgba
branch
from
d7858c3 to
bf332fb
Compare
474: Apply alpha blend modes and coloration to textures based on sprite data. r=pathunstrom a=ironfroggy I know there was debate before about where `opacity` and `color` data should live, but i wanted to open the PR with the customizations I've been using to start the discussion again with something concrete. Co-authored-by: Calvin Spealman <ironfroggy@gmail.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
I know there was debate before about where
opacityandcolordata should live, but i wanted to open the PR with the customizations I've been using to start the discussion again with something concrete.