Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Game Object Model #500

Merged
merged 8 commits into from
Jul 25, 2020
Merged

Implement the Game Object Model #500

merged 8 commits into from
Jul 25, 2020

Conversation

AstraLuma
Copy link
Member

@AstraLuma AstraLuma commented Jul 11, 2020 •
edited
Loading

Implements a standard interface for "game objects" (things that participate in the tree and receive events)

Part of #492

@AstraLuma AstraLuma requested a review from a team as a code owner July 11, 2020 17:35
@AstraLuma AstraLuma marked this pull request as draft July 11, 2020 17:39
@AstraLuma
Copy link
Member Author

I did make a FilteredView but I haven't included it yet because we don't have a need.

@AstraLuma AstraLuma marked this pull request as ready for review July 11, 2020 21:33
@AstraLuma
Copy link
Member Author

I'm deliberately leaving out the engine changes in this PR.

@pathunstrom pathunstrom mentioned this pull request Jul 16, 2020
Closed
@pathunstrom
Copy link
Collaborator

Leaving a few comments here just to note the discussion:

  • Subsprites and relative to parent positioning will be a valuable feature. We don't need to add it in the PR, so will open an issue once this one is merged.
  • Adding a children kwarg to the GameObject init that can be passed to the Children would allow us to add objects on instantiation. Not a blocker, but a thing we should consider.

pathunstrom
pathunstrom approved these changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, going to wait on bors until we're sure everything we want is here.

@AstraLuma
Copy link
Member Author

Updated for camera.

pathunstrom
pathunstrom approved these changes Jul 25, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 25, 2020

Build succeeded:

@bors bors bot merged commit 07eaf20 into ppb:canon Jul 25, 2020
@AstraLuma AstraLuma deleted the gom branch August 8, 2020 18:06
@pathunstrom pathunstrom mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @pathunstrom