Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds show_cursor attribute to BaseScene to control cursor visibility. #504

Merged
merged 3 commits into from
Aug 16, 2020
Merged

Adds show_cursor attribute to BaseScene to control cursor visibility. #504

merged 3 commits into from
Aug 16, 2020

Conversation

pathunstrom
Copy link
Collaborator

Resolves #491

@pathunstrom pathunstrom requested a review from a team as a code owner August 9, 2020 19:29
@pathunstrom pathunstrom self-assigned this Aug 9, 2020
AstraLuma
AstraLuma requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this will work with scene stacks (eg, a pause menu has a cursor but its parent doesn't).

@pathunstrom
Copy link
Collaborator Author

Oh, right, should do the check on SceneContinued too.

@pathunstrom pathunstrom requested a review from AstraLuma August 16, 2020 18:35
AstraLuma
AstraLuma approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 16, 2020

Canceled.

@AstraLuma
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request Aug 16, 2020
@bors @pathunstrom
Merge #504
dad413c 
504: Adds show_cursor attribute to BaseScene to control cursor visibility. r=astronouth7303 a=pathunstrom

Resolves #491 

Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 16, 2020

Build failed:

@pathunstrom
Copy link
Collaborator Author

bors retry

bors bot added a commit that referenced this pull request Aug 16, 2020
@bors @pathunstrom
Merge #504
3d9f4ef 
504: Adds show_cursor attribute to BaseScene to control cursor visibility. r=astronouth7303 a=pathunstrom

Resolves #491 

Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 16, 2020

Build failed:

@pathunstrom
Copy link
Collaborator Author

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 16, 2020

Build succeeded:

@bors bors bot merged commit c648c98 into ppb:canon Aug 16, 2020
@pathunstrom pathunstrom deleted the 491-show-cursor branch October 24, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees

@pathunstrom pathunstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add scene prop to hide cursor
2 participants
@pathunstrom @AstraLuma