Add 'libmodplug' to RHEL prereqs in docs #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to PursuedPyBear! Don't forget to add yourself |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2020
515: Add 'libmodplug' to RHEL prereqs in docs r=AstraLuma a=josephbmanley ## Error Version: `0.9.0` OS: `Linux (Fedora Silverblue)` I was getting an exception on run due to `MIX_INIT_MOD` from the following code being passed into `Mix_Init`: https://github.com/ppb/pursuedpybear/blob/f34fed3cd34b9b5da2629bbc0e4de29c17619b56/ppb/systems/sound.py#L88 Looking into this, I found that this is due to the `SDL2_mixer` binary build for Fedora is missing the `MOD` support for whatever reason. Full error (when missing package) for reference: ``` Traceback (most recent call last): File "main.py", line 12, in <module> ppb.run(setup=setup) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/__init__.py", line 122, in run with make_engine(setup, starting_scene=starting_scene, title=title, **engine_opts) as eng: File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/engine.py", line 107, in __enter__ self.start_systems() File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/engine.py", line 124, in start_systems self.exit_stack.enter_context(system) File "/usr/lib64/python3.7/contextlib.py", line 427, in enter_context result = _cm_type.__enter__(cm) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/systems/sound.py", line 88, in __enter__ mix_call(Mix_Init, MIX_INIT_FLAC | MIX_INIT_MOD | MIX_INIT_MP3 | MIX_INIT_OGG) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/systems/_sdl_utils.py", line 94, in mix_call raise SdlMixerError(f"Error calling {func.__name__}: {err.decode('utf-8')}") ppb.systems._sdl_utils.SdlMixerError: Error calling Mix_Init: MOD support not available ``` ## Solution To solve this error I installed the `libmodplug` package. ## Code Changes This PR just updates the docs to include the `libmodplug` package for Fedora, Centos, and RHEL. Co-authored-by: Joseph Manley <j@cloudsumu.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2020
515: Add 'libmodplug' to RHEL prereqs in docs r=AstraLuma a=josephbmanley ## Error Version: `0.9.0` OS: `Linux (Fedora Silverblue)` I was getting an exception on run due to `MIX_INIT_MOD` from the following code being passed into `Mix_Init`: https://github.com/ppb/pursuedpybear/blob/f34fed3cd34b9b5da2629bbc0e4de29c17619b56/ppb/systems/sound.py#L88 Looking into this, I found that this is due to the `SDL2_mixer` binary build for Fedora is missing the `MOD` support for whatever reason. Full error (when missing package) for reference: ``` Traceback (most recent call last): File "main.py", line 12, in <module> ppb.run(setup=setup) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/__init__.py", line 122, in run with make_engine(setup, starting_scene=starting_scene, title=title, **engine_opts) as eng: File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/engine.py", line 107, in __enter__ self.start_systems() File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/engine.py", line 124, in start_systems self.exit_stack.enter_context(system) File "/usr/lib64/python3.7/contextlib.py", line 427, in enter_context result = _cm_type.__enter__(cm) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/systems/sound.py", line 88, in __enter__ mix_call(Mix_Init, MIX_INIT_FLAC | MIX_INIT_MOD | MIX_INIT_MP3 | MIX_INIT_OGG) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/systems/_sdl_utils.py", line 94, in mix_call raise SdlMixerError(f"Error calling {func.__name__}: {err.decode('utf-8')}") ppb.systems._sdl_utils.SdlMixerError: Error calling Mix_Init: MOD support not available ``` ## Solution To solve this error I installed the `libmodplug` package. ## Code Changes This PR just updates the docs to include the `libmodplug` package for Fedora, Centos, and RHEL. Co-authored-by: Joseph Manley <j@cloudsumu.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2020
515: Add 'libmodplug' to RHEL prereqs in docs r=AstraLuma a=josephbmanley ## Error Version: `0.9.0` OS: `Linux (Fedora Silverblue)` I was getting an exception on run due to `MIX_INIT_MOD` from the following code being passed into `Mix_Init`: https://github.com/ppb/pursuedpybear/blob/f34fed3cd34b9b5da2629bbc0e4de29c17619b56/ppb/systems/sound.py#L88 Looking into this, I found that this is due to the `SDL2_mixer` binary build for Fedora is missing the `MOD` support for whatever reason. Full error (when missing package) for reference: ``` Traceback (most recent call last): File "main.py", line 12, in <module> ppb.run(setup=setup) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/__init__.py", line 122, in run with make_engine(setup, starting_scene=starting_scene, title=title, **engine_opts) as eng: File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/engine.py", line 107, in __enter__ self.start_systems() File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/engine.py", line 124, in start_systems self.exit_stack.enter_context(system) File "/usr/lib64/python3.7/contextlib.py", line 427, in enter_context result = _cm_type.__enter__(cm) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/systems/sound.py", line 88, in __enter__ mix_call(Mix_Init, MIX_INIT_FLAC | MIX_INIT_MOD | MIX_INIT_MP3 | MIX_INIT_OGG) File "/var/home/vetra/Projects/build-ppb-action/test_project/.venv/lib/python3.7/site-packages/ppb/systems/_sdl_utils.py", line 94, in mix_call raise SdlMixerError(f"Error calling {func.__name__}: {err.decode('utf-8')}") ppb.systems._sdl_utils.SdlMixerError: Error calling Mix_Init: MOD support not available ``` ## Solution To solve this error I installed the `libmodplug` package. ## Code Changes This PR just updates the docs to include the `libmodplug` package for Fedora, Centos, and RHEL. Co-authored-by: Joseph Manley <j@cloudsumu.com>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error
Version:
0.9.0OS:
Linux (Fedora Silverblue)I was getting an exception on run due to
MIX_INIT_MODfrom the following code being passed intoMix_Init:pursuedpybear/ppb/systems/sound.py
Line 88 in f34fed3
Looking into this, I found that this is due to the
SDL2_mixerbinary build for Fedora is missing theMODsupport for whatever reason.Full error (when missing package) for reference:
Solution
To solve this error I installed the
libmodplugpackage.Code Changes
This PR just updates the docs to include the
libmodplugpackage for Fedora, Centos, and RHEL.