Rename BaseScene to Scene #569 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recation warning exists when using BaseScene
mgmanzella
changed the title
pathunstrom
requested changes
Feb 21, 2021
…name in CONTRIBUTORS.md
|
This looks good! Thanks so much! Closes #569 bors r+ |
pathunstrom
approved these changes
Feb 21, 2021
bors bot
added a commit
that referenced
this pull request
Feb 21, 2021
583: Rename BaseScene to Scene #569 r=pathunstrom a=mgmanzella Addresses #569 - Renamed `ppb.BaseScene` to `Scene` in scenes.py (using PyCharm refactor) - Added child class of `Scene` called `BaseScene` with a deprecation warning (and a comment "to be removed in 0.14 or 1.0") - Import `Scene` into `__init__.py` - Updates tests to use `ppb.Scene` - Added test to confirm BaseScene raises deprecation warning - For sanity check, ran `python -m viztests` after installing local version ppb Co-authored-by: Morisa Manzella <manzella.morisa@gmail.com>
|
Timed out. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #569
ppb.BaseScenetoScenein scenes.py (using PyCharm refactor)ScenecalledBaseScenewith a deprecation warning (and a comment "to be removed in 0.14 or 1.0")Sceneinto__init__.pyppb.Scenepython -m viztestsafter installing local version ppb