Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration CLI tests #483

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integration CLI tests #483

wants to merge 2 commits into from

Conversation

AshwinHIBM
Copy link
Contributor

Job to trigger scripts in ppc64le-cloud/docker-ce-build#225
These tests will run against https://github.com/docker/cli

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AshwinHIBM
Once this PR has been reviewed and has the lgtm label, please assign rajalakshmi-girish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2024
@ppc64le-cloud-bot
Copy link
Contributor

Hi @AshwinHIBM. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 9, 2024
@AshwinHIBM AshwinHIBM mentioned this pull request Aug 9, 2024
Merged
@mkumatag
Copy link
Member

mkumatag commented Aug 9, 2024

/ok-to-test

@ppc64le-cloud-bot ppc64le-cloud-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2024
@AshwinHIBM AshwinHIBM marked this pull request as ready for review August 16, 2024 05:58
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
@AshwinHIBM
Copy link
Contributor Author

@Rajalakshmi-Girish ppc64le-cloud/docker-ce-build#225 merged. Can you PTAL at this PR?

Rajalakshmi-Girish
Rajalakshmi-Girish reviewed Aug 20, 2024
View reviewed changes
config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated
cluster: k8s-ppc64le-cluster
labels:
preset-build-docker: "true"
cron: 0 14 * * *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time set at cron clashes with the existing job periodic-integration-test-docker's cron time.
Choose a time stamp at which no other job gets trigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted periodic-integration-test-docker to 14:30 master...AshwinHIBM:test-infra:integration-cli#diff-d529e4fce74de0ef2b5f5f6f4131d73c755e5895ad4749261c3a15a2bcc6e61dR171

Rajalakshmi-Girish
Rajalakshmi-Girish reviewed Aug 20, 2024
View reviewed changes
config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated
requests:
cpu: "4000m"
limits:
cpu: "4000m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you have test run this job in your development cluster and visualized the view of test results in junit tab?

Rajalakshmi-Girish
Rajalakshmi-Girish reviewed Aug 20, 2024
View reviewed changes
config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated
- image: quay.io/powercloud/docker-ce-build@sha256:f93b6d36ad414d30f584c6555d8c2116de58bd56601da36f4e13d4b5b624114a
resources:
requests:
cpu: "4000m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this job would also need 4000m cpu like other docker jobs?
As this one aims at testing CLI, I suppose a lesser resource should suffice. Can you analyse on how much is the cpu required by this job?(Compare resource usage with similar job run upstream on x86)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream job uses 4000m but my experiment showed I can safely run periodic-integration-cli-docker with 2000 and periodic-integration-test-docker with 4000.
master...AshwinHIBM:test-infra:integration-cli#diff-d529e4fce74de0ef2b5f5f6f4131d73c755e5895ad4749261c3a15a2bcc6e61dR147
master...AshwinHIBM:test-infra:integration-cli#diff-d529e4fce74de0ef2b5f5f6f4131d73c755e5895ad4749261c3a15a2bcc6e61dR147

@AshwinHIBM
Copy link
Contributor Author

Commit 508c60a is for setting up the integration-cli-docker job and commit f61554d is for adjusting the CPU usage and timing of the periodic-integration-test-docker job. Please note, the collective diff view of the PR isn't showing colours as I would expect.

@AshwinHIBM
Copy link
Contributor Author

/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AshwinHIBM @ppc64le-cloud-bot @mkumatag @Rajalakshmi-Girish