Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] SRI hashes to static files #167

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[ADD] SRI hashes to static files #167

merged 1 commit into from
Jan 21, 2025

Conversation

ppfeufer
Copy link
Owner

Description

Added

  • SRI hashes to static files

Changed

  • Minimum requirements
    • Alliance Auth >= 4.6.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.16%. Comparing base (4b5280a) to head (17f644f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...a_bulletin_board/templatetags/aa_bulletin_board.py 82.61% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   97.36%   96.16%   -1.20%     
==========================================
  Files          10       12       +2     
  Lines         227      260      +33     
  Branches       12       15       +3     
==========================================
+ Hits          221      250      +29     
- Misses          3        5       +2     
- Partials        3        5       +2     
Files with missing lines Coverage Δ
aa_bulletin_board/constants.py 100.00% <100.00%> (ø)
aa_bulletin_board/helper/static_files.py 100.00% <100.00%> (ø)
...a_bulletin_board/templatetags/aa_bulletin_board.py 84.62% <82.61%> (-15.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5280a...17f644f. Read the comment docs.

@ppfeufer ppfeufer merged commit e7b359b into master Jan 21, 2025
54 of 56 checks passed
@ppfeufer ppfeufer deleted the sri-hashes branch January 21, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant