Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alliance Auth v4 compatibility update #87

Merged
merged 64 commits into from
Mar 15, 2024
Merged

Alliance Auth v4 compatibility update #87

merged 64 commits into from
Mar 15, 2024

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Oct 22, 2023

Description

Added

  • Compatibility to Alliance Auth v4
    • Bootstrap 5
    • Django 4.2

Fixed

  • Pluralisation in a template string

Changed

  • JS modernized
  • CSS modernizes
  • Templates changed to Bootstrap 5
  • Switched from CKEditor 4 to CKEditor 5 (Configuration update necessary, see CHANGELOG)
  • Translations improved
    • French
    • Chinese
    • Spanish

Removed

  • Compatibility to Alliance Auth v3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #87 (b7a036b) into master (907a664) will decrease coverage by 0.83%.
The diff coverage is 95.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   98.21%   97.37%   -0.83%     
==========================================
  Files          10       10              
  Lines         223      228       +5     
  Branches       11       12       +1     
==========================================
+ Hits          219      222       +3     
- Misses          2        3       +1     
- Partials        2        3       +1     
Files Coverage Δ
aa_bulletin_board/__init__.py 100.00% <100.00%> (ø)
aa_bulletin_board/auth_hooks.py 100.00% <ø> (ø)
aa_bulletin_board/models.py 100.00% <100.00%> (ø)
...a_bulletin_board/templatetags/aa_bulletin_board.py 100.00% <ø> (ø)
aa_bulletin_board/views.py 100.00% <100.00%> (ø)
aa_bulletin_board/forms.py 86.37% <81.82%> (-2.82%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907a664...b7a036b. Read the comment docs.

@ppfeufer ppfeufer self-assigned this Oct 25, 2023
@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 2 times, most recently from ab9e1bf to ab460ee Compare December 7, 2023 09:32
@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 3 times, most recently from b48dd71 to 96dfbb3 Compare December 21, 2023 19:06
@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 2 times, most recently from e68e71a to 6266017 Compare January 1, 2024 21:06
@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 2 times, most recently from 4e14104 to 78d3c1b Compare January 12, 2024 18:31
@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 2 times, most recently from c2b7f05 to 7b90f1a Compare February 1, 2024 06:24
@ppfeufer ppfeufer force-pushed the allianceauth-v4 branch 2 times, most recently from b9fdf25 to c8843d1 Compare February 7, 2024 18:48
@ppfeufer ppfeufer changed the title Alliance Auth v4 compatibility Alliance Auth v4 compatibility update Feb 29, 2024
@ppfeufer ppfeufer marked this pull request as ready for review March 15, 2024 17:07
@ppfeufer ppfeufer merged commit fbb46a9 into master Mar 15, 2024
86 of 88 checks passed
@ppfeufer ppfeufer deleted the allianceauth-v4 branch March 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant