Add an Android bindings project #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove all binaries from this PR. We'll run the GH action once after it's merged. |
|
I just removed them. |
Removed upstream: - libsdl-org/SDL@9c8c254 - libsdl-org/SDL@f06f761
|
Lgtm. I bundled one additional change here for a header that's been removed upstream. |
Susko3
reviewed
Apr 15, 2024
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SDL3-CS.Tests", "SDL3-CS.Tests\SDL3-CS.Tests.csproj", "{CF980481-8227-4BED-970E-6433C83F64CB}" | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SDL3-CS-Android", "SDL3-CS-Android\SDL3-CS-Android.csproj", "{CA28F49C-D0BE-47D6-9E82-7A0B8C380B8B}" |
There was a problem hiding this comment.
Hmm, we'd usually name this SDL3-CS.Android, not -Android
There was a problem hiding this comment.
Yep, I've got fixes on the way...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Android bindings project to the repository, and a workflow to build binaries for Android.
I separated it from the original project since building it requires Xamarin, and I thought that most consumers of this project won't like it.
Workflow may need to be run once to replace my binaries. Couldn't test workflow since I couldn't run in my forked repository, probably due to secrets?