-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pressing keys on a hardware keyboard showing the software keyboard #5274
Merged
bdach
merged 4 commits into
ppy:master
from
Susko3:fix-hardware-keyboard-showing-soft-keyboard
Jun 28, 2022
Merged
Fix pressing keys on a hardware keyboard showing the software keyboard #5274
bdach
merged 4 commits into
ppy:master
from
Susko3:fix-hardware-keyboard-showing-soft-keyboard
Jun 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered a bug, this has completely broken |
Fixes `AndroidInputConnection` sometimes not working properly because `OnCreateInputConnection()` was not being called by Android.
1 task
peppy
approved these changes
Jun 28, 2022
Probably best to get a second check on this one, looks okay code-wise though. |
bdach
approved these changes
Jun 28, 2022
This was referenced Jun 29, 2022
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
and forcingOnCheckIsTextEditor() => true
is the probable causeBy default, Android will show the software keyboard while text input is active even if a hardware keyboard is connected. And since we were always returning a valid
IInputConnection
, Android would "conveniently" show the software keyboard when any hardware keys are pressed.Pressing keys will (re)focus the current view and probe
OnCreateInputConnection()
to see if the input method is to be activated.The docs specify to return
null
when input methods are not supported by a specificView
. Since we have only oneView
, returningnull
here means to disable text input for the time being (until a textbox is focused andAndroidTextInput
is activated).