Copy DotSettings CodeInspections from osu! sln
#5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
requested changes
Oct 5, 2022
osu-framework.sln.DotSettings
Outdated
Comment on lines
65
to
66
| <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ConvertClosureToMethodGroup/@EntryIndexedValue">HINT</s:String> | ||
| <s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ConvertClosureToMethodGroup/@EntryIndexedValue">WARNING</s:String> |
There was a problem hiding this comment.
I think this one is intentional, because for high performance scenarios using method groups will allocate the delegate every time whereas a closure won't (as backwards as that sounds).
This was documented here: dotnet/roslyn#5835 and will be fixed in .NET 7. I'd prefer this remains until that point.
In high performance scenarios a closure might be preferred.
This seems too verbose for framework, used in quite a lot of places where it makes sense.
smoogipoo
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the inspections were weaker in o!f, except
UnusedParameter.Localwhich lowered fromwarningtohint.