Apply NRT to all files where it can be easily applied #5867
Conversation
| @@ -14,7 +12,7 @@ public static class TestingExtensions | |||
| /// <summary> | |||
| /// Find all children recursively of a specific type. As this is expensive and dangerous, it should only be used for testing purposes. | |||
| /// </summary> | |||
| public static IEnumerable<T> ChildrenOfType<T>(this Drawable drawable) | |||
| public static IEnumerable<T> ChildrenOfType<T>(this Drawable? drawable) | |||
There was a problem hiding this comment.
What's with this one? Is anyone really calling ChildrenOfType() on a null reference?
There was a problem hiding this comment.
Might be okay. But also may have been a weird osu! test usage (I likely would not have made this change without a good reason). Will need to run tests against this before applying.
There was a problem hiding this comment.
If you don't recall from memory then I'm not sure I care that much for you to go check. I was mostly curious is all.
There was a problem hiding this comment.
Turns out it's to ease cases like this:
There's around 30 usages osu! side which would need updating if we revert this. I think making the method nullable makes it a touch more flexible though, given its intended purpose.
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Without other bindable classes following suit, this will only lead to headaches. Noticed in an osu!-side usage.
Something I've had sitting around. Tested against osu! (see ppy/osu#24019).
Another pass will follow, but feel that getting this one out of the way is a good first step.