Remove most locking overhead in TripleBuffer
#5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's such an edge case it's not going to improve anything anyway.
|
Can't see any fault with this, theoretically speaking. The split critical section in Will probably ask for a second review though... |
bdach
approved these changes
Jul 10, 2023
|
(checked with smoogi and he was fine with getting this in) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of those things I see in passing and can't un-see. Call this a developer indulgence rather than an optimisation if you want.
The time profiling results should be taken with a grain of salt. Of note is the reduction in lock %, mainly in
finishUsage.