Fix texture uploads getting corrupted on Metal with non-Apple GPUs #5924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm it fixes the issue still. |
|
Merging with the intent of undoing in the near future. |
peppy
approved these changes
Jul 12, 2023
frenzibyte
added a commit
to frenzibyte/osu-framework
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test thoroughly and check multiple times that this does fix the issue, I have no explanation for how this fixes the issue (I rather have suspicion it's hiding the issue instead), but I cannot reproduce this on my machine (M1 Pro) and there's not much to lose in flushing before drawcall so why not.