Fix potential texture corruption on Veldrid #5928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves noticeable texture corruption on osu!:
It's possible to have a draw frame which processes enqueued texture uploads but doesn't have any draw nodes to render to the screen (i.e. no calls to
DrawVertices
), therefore the texture upload commands continue to the next frame without being submitted and the staging resources incorrectly return back to the pool. This PR resolves the bug by ensuring texture upload commands are submitted before the end of the frame.Reproducing this bug requires a fresh game state that has absolutely no draw node. Can be repro'd with this simple code in
SampleGameGame
:Before:
After: