Make KeyBindingContainer.Prioritised work for positional input too
#5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
changed the title
KeyBindingContainer.IsPrioritised work for positional input too KeyBindingContainer.Prioritised work for positional input too
|
I think this makes sense. The resultant code osu!-side also looks better (less-hacky) than what we have as a result (for reference: https://github.com/ppy/osu/compare/master...bdach:osu:remove-global-action-container-hack?expand=1). |
peppy
approved these changes
Aug 16, 2023
smoogipoo
approved these changes
Aug 17, 2023
bdach
added a commit
to bdach/osu
that referenced
this pull request
Aug 21, 2023
As described in ppy#24248, the workaround employed by `GlobalActionContainer`, wherein it tried to handle actions with priority before its children by being placed in front of the children and not _actually containing_ said children, is blocking the resolution of some rather major input handling issues that allow key releases to be received by deparented drawables. To resolve, migrate `GlobalActionContainer` to use `Prioritised`, which can be done without regressing certain mouse button flows after ppy/osu-framework#5966.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC.
This change would allow to replace this game-side workaround with usage of
KeyBindingContainer.IsPrioritised. The workaround in question is a blocker in resolving a game-side p0 issue (ppy/osu#24248 (comment)).More specifically, this change ensures that the game-side workaround can be replaced with
IsPrioritisedwithout regressing issues like ppy/osu#6026. The fail case is when a child of theKeyBindingContaineris handling a plain input handler method likeOnMouseDown(), and handles the positional input before theKeyBindingContainereven has a chance to see it. This is covered in the added test cases.