New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `KeyBindingContainer` propagating release events to removed drawables #5975

Merged

peppy merged 3 commits into ppy:master from bdach:key-binding-container-unrooting

Aug 22, 2023

Collaborator

bdach commented Aug 21, 2023 •

edited by peppy

Loading

Closes System.InvalidOperationException: Cannot call InternalChild unless there's exactly one Drawable in Children (currently 0)! osu#24248
Must not be merged without Remove global action container input queue workaround osu#24610 (or else regressions will ensue)

bdach added 3 commits

August 21, 2023 18:06


          Rewrite key binding container test asserts to use matcher style

8b86e25


          Add failing tests for receptor removal scenario

ebcab87


          Fix KeyBindingContainer propagating release events to removed drawa…

d1aa9e1

…bles

bdach added area:input type:reliability labels

pull-request-size bot added the size/M label

peppy approved these changes

View reviewed changes

peppy merged commit 036defa into ppy:master

15 of 20 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:input size/M type:reliability