Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UTF-8 console encoding on windows #6170

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented Feb 2, 2024

This is in a try/catch because it can fail, and is only set on windows because UTF-8 is not the default there. Emoji already works fine when running unit tests from Rider, so setting this in DesktopGameHost is not needed.

Before (Rider Run/Debug on Windows):

image

After:

image

@smoogipoo smoogipoo merged commit 057c0e7 into ppy:master Feb 3, 2024
21 checks passed
@Susko3 Susko3 deleted the use-utf8-windows branch February 3, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants