Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest SDL3-CS friendly overload and null-terminated UTF8 conversion #6245
Update to latest SDL3-CS friendly overload and null-terminated UTF8 conversion #6245
Changes from 3 commits
126a55d
faeb22a
384ddf7
c92774f
041900c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 16 in osu.Framework/Platform/SDL/SDL3Clipboard.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 16 in osu.Framework/Platform/SDL/SDL3Clipboard.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Code Quality
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Build only (Android)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 143 in osu.Framework/Platform/SDL/SDL3GraphicsSurface.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 72 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 204 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 277 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 299 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 452 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 463 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Code Quality
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (iOS)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Build only (Android)
Check failure on line 469 in osu.Framework/Platform/SDL3Window.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, MultiThreaded)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, SingleThread)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Code Quality
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (Linux, ubuntu-latest, Release, MultiThreaded)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (Linux, ubuntu-latest, Debug, SingleThread)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (macOS, macos-latest, Debug, MultiThreaded)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Build only (iOS)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (macOS, macos-latest, Debug, SingleThread)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Build only (Android)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (Windows, windows-latest, Debug, SingleThread)
Check failure on line 96 in osu.Framework/Platform/Windows/WindowsWindow.cs
GitHub Actions / Test (Windows, windows-latest, Debug, MultiThreaded)