Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect assertion and possible nullref #6293

Merged
merged 1 commit into from
May 21, 2024

Conversation

smoogipoo
Copy link
Contributor

I've had the following osu! side tests fail when using a local framework checkout:

TestConfineAlwaysInFullscreen
TestConfineAlwaysUserSetting
 at osu.Framework.Logging.ThrowingTraceListener.Fail(String message1, String message2) in /Users/smgi/Repos/osu-framework/osu.Framework/Logging/ThrowingTraceListener.cs:line 27
   at System.Diagnostics.TraceInternal.Fail(String message, String detailMessage)
   at System.Diagnostics.Debug.Fail(String message, String detailMessage)
   at osu.Framework.Graphics.UserInterface.TextBox.unbindInput(TextBox next) in /Users/smgi/Repos/osu-framework/osu.Framework/Graphics/UserInterface/TextBox.cs:line 1380
   at osu.Framework.Graphics.UserInterface.TextBox.Dispose(Boolean isDisposing) in /Users/smgi/Repos/osu-framework/osu.Framework/Graphics/UserInterface/TextBox.cs:line 539
   at osu.Framework.Graphics.Drawable.Dispose() in /Users/smgi/Repos/osu-framework/osu.Framework/Graphics/Drawable.cs:line 80

Basically, this can happen if the TextBox is disposed before getting loaded.

@peppy peppy enabled auto-merge May 21, 2024 11:33
@peppy peppy merged commit d48e771 into ppy:master May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants