Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix texture wrapping not updating on consecutive WhitePixel use #6350

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Fix texture wrapping not updating on consecutive WhitePixel use #6350

merged 7 commits into from
Aug 8, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo
Fix class name + update method name
1977580
@smoogipoo
Restore helper method to create dummy texture
ab6d905 
This is actually used in osu! tests, and I'd rather this PR be
non-breaking.
@smoogipoo
Fix dodgy implementations now that DummyRenderer is an actual renderer
3f06897
@smoogipoo
Fix another test
0750044 
The assertions are kinda dodgy in this case, but it is what it is. This
is the only assertion in `Renderer`, so it's maybe even a matter for the
implementations to resolve by not doing draw-thread-requiring calls in
the ctor.
@smoogipoo
Copy link
Contributor Author

This PR blew up unfortunately due to fixing tests because DummyRenderer now has an actual Renderer-based implementation, rather than being totally separate from everything else.

The only two important commits are aeffd4e and 3a61875, the rest is fluff.

@peppy peppy merged commit 4658a3f into ppy:master Aug 8, 2024
21 checks passed
@Jumprocks1 Jumprocks1 mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:graphics size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HP bar disappears before drum rolls on some maps
2 participants
@smoogipoo @peppy