Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BASS libraries #6352

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Update BASS libraries #6352

merged 4 commits into from
Aug 9, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Aug 9, 2024

Turns out we're a little bit behind. Could not confirm locally whether this fixes ppy/osu#26879 but since a game release is coming we might as well update the libraries and see if it helps.

Old versions:

2024-08-09 06:17:30 [verbose]: BASS version:           2.4.16.7
2024-08-09 06:17:30 [verbose]: BASS FX version:        2.4.12.6
2024-08-09 06:17:30 [verbose]: BASS MIX version:       2.4.11.1

New versions:

2024-08-09 07:11:47 [verbose]: BASS version:           2.4.17.0
2024-08-09 07:11:47 [verbose]: BASS FX version:        2.4.12.6
2024-08-09 07:11:47 [verbose]: BASS MIX version:       2.4.12.0

Note iOS is not in this diff because it's already been using the latest versions for some time now. Also BASS FX is still on latest version.

  • Windows x86
  • Windows x64
  • Windows arm64 (cannot test due to lack of win-arm64 libveldrid-spirv)
  • macOS
  • Linux x86
  • Linux x64
  • Android

@peppy
Copy link
Member

peppy commented Aug 9, 2024

I don't think we need to test x86 (should be fine). A quick check on linux by @smoogipoo should be enough to go ahead with this (and android if @bdach happens to be around).

@smoogipoo
Copy link
Contributor

Lgtm on linux.

@peppy note that we'll need a nativelibs package + update prior to a new framework release.

@smoogipoo smoogipoo closed this Aug 9, 2024
@smoogipoo smoogipoo reopened this Aug 9, 2024
@smoogipoo smoogipoo merged commit 3dc9db5 into ppy:master Aug 9, 2024
29 of 32 checks passed
@frenzibyte frenzibyte deleted the update-bass branch August 10, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gameplay suddenly jumps back/seeks for a frame
3 participants