Fix tempo attributes being ignored #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
approved these changes
Aug 9, 2024
|
Kinda crazy how no-one noticed this for 8 years |
|
This will likely also fix people complaining that the audio offset changes during tempo adjustments in unexpected ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ppy/osu#29332
It seems the tempo attributes were being applied to the wrong stream handle, so the attributes were ignored completely. With the fix, the audio seems to match osu! stable.
Something else that's interesting is that if you disable the quick algorithm, the audio becomes even better and I didn't notice an increase in CPU usage while using it. Maybe that's something that can be looked into later.