Fix renderers can't batch vertices with the same blending parameters in some cases #6366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following scenario.
You may assume that these boxes will be batched and drawn in a single draw call, however this is not the case:
That's because each
DrawNode
sets its blending parameters insideDraw
method and the problem here is thatCompositeDrawNode
does the same. But this is not needed since each child will set their own blending later on (which is computed withDrawColourInfo
and inherited from the parent), thus making blending update inside composite practically useless.Result (both boxes drawn together):