Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crowdin.yml to support multiple namespace levels #273

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

ItsShamed
Copy link
Contributor

Last piece for fully supporting localisation with multiple namespace levels.

Since I can't run Crowdin myself I checked against the documentation: source and web ignore should both be okay. Not quite sure for the translation key though.

Last piece for fully supporting localisation using multiple namespace levels.

Double-checked against Crowdin documentation: `source` and web `ignore` should both be okay. Not quite sure for the `translation` key though.
@peppy peppy self-requested a review July 30, 2023 15:04
@peppy
Copy link
Member

peppy commented Jul 30, 2023

Is this supposed to add the ability for namespaces deeper than what we have?

2023-07-31 00 30 27@2x

Should I test with another level of namespace nesting?

If so it seems to work:

2023-07-31 00 47 16@2x

@ItsShamed
Copy link
Contributor Author

I don't believe that we will ever go beyond the 2nd level of subnamespacing anytime soon, but in theory it should be automatically supported thanks to the ** wildcard. I think localisation analyser should support this as well.

@peppy
Copy link
Member

peppy commented Jul 31, 2023

So is the test I did correct? I am not sure because there were already localisations in a folder that shouldn't have worked previously and were working fine.

@smoogipoo
Copy link
Contributor

smoogipoo commented Jul 31, 2023

If it helps, namespaced localisations are themselves a new thing that only gained support after the recent LocalisationAnalyser changes. For example that BarHitErrorMeterStrings.resx file is a new one that's only been added recently.

So as far as I understand this is fixing the export from osu-resources (that now has these new files) to crowdin, which currently doesn't have these files (https://crowdin.com/project/osu-web/ja#/client/osu.Game.Resources/Localisation)

@peppy
Copy link
Member

peppy commented Jul 31, 2023

Right, I didn't realise the files weren't yet on crowdin (incorrect testing). Will test again.

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling this in for a full test run

@peppy peppy merged commit 1ce82e2 into ppy:master Aug 14, 2023
1 check passed
@peppy
Copy link
Member

peppy commented Aug 14, 2023

Worked as expected 👍

2023-08-14 22 28 37@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants