Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sprites for slider end / tick misses #300

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 25, 2023

Pixelmator project file: slider end miss tick.zip

@bdach
Copy link
Collaborator

bdach commented Dec 25, 2023

Not sure about the quality of these exports - this is what gimp shows me when I disable the alpha layer:

image
image

I'd expect the red/orange to extend to the bounds of the entire image and only be masked by alpha, rather than stop at the edges of the glow. Unlucky sampling could cause the outer parts of the glow to darken.

@peppy
Copy link
Member Author

peppy commented Dec 25, 2023

I'd expect the red/orange to extend to the bounds of the entire image and only be masked by alpha, rather than stop at the edges of the glow.

I'm not sure how much this matters?

I'll fix the edge pixels though.

@bdach
Copy link
Collaborator

bdach commented Dec 25, 2023

I'm not sure how much this matters?

I mean I'm probably not too fussed, but given the debacle about proper exports for the mod extender thing a while back I figured you might?

@peppy
Copy link
Member Author

peppy commented Dec 25, 2023

As long as there's a glow the visibility of any incorrect RGB on alpha pixels is already negligible since it occurs on a transition of 0.01 to 0.00 alpha, so it's not a huge concern 👍.

Please re-check now, there edge pixels should at least be fixed.

@bdach
Copy link
Collaborator

bdach commented Dec 25, 2023

Looks better now, yep:

image
image

@bdach bdach merged commit bbb35be into ppy:master Dec 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants