Fix disparate score token types being used as one type #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replay upload flow and the user statistics update flow would rely on the score token sent by client to spectator server in `BeginPlaySession()`, in order to unmap the score token to a solo score ID when processing finishes. However, spectator server thus far has not been aware that there are actually _two_ types of token - and to be fair, client gave it no practical way to actually know this. In solo, the token ID comes from `solo_score_tokens`, and in multiplayer, the token ID comes from `multiplayer_score_links`. Spectator server has however been treating both types as the solo score type. In particular, this could mean that the replay recording flow would royally confuse things and unmap the token to a score ID wrong, and as such, upload an entirely misattributed replay. To resolve, leverage the updated client contract which now passes a `ScoreToken` with an explicit type rather than a `long` to do the right thing for both types of token.
bdach
added a commit
to bdach/osu-infrastructure
that referenced
this pull request
Sep 5, 2023
This PR adds documentation about the multiplayer score submission flow in the form of a sequence diagram. It was primarily created by taking the existing solo score submission flow sequence diagram and adapting it to the differences specific to the multi flow (different endpoints, different tables, different ID schemes). This diagram does not describe the current state of things. It describes where things _should_ be after a sequence of some already-PRed changes such as: - ppy/osu-web#10437 - ppy/osu#24697 - ppy/osu-server-spectator#185 and some changes that are still being worked on (primarily client-side at this point). The main goal of the document is to inform the changes above. (And to be something that I can easily refer to, because I keep looking up the same information over and over right now.)
4 tasks
|
Closing for now to keep things clean. See ppy/osu-infrastructure#24 for rationale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side counterpart to ppy/osu#24697. See description of said pull for rationale.