Fix incorrect reporting of user rank in room in case of score ties #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should match web, in theory: https://github.com/ppy/osu-web/blob/8f70623d02f6203cd877c64c6232f96061da0071/app/Models/Multiplayer/UserScoreAggregate.php#L176-L177 Not sure about the CTE usage but it's one row and I'd rather try this than duplicate the subquery.
peppy
approved these changes
Jul 25, 2024
| @@ -465,8 +465,10 @@ public async Task<int> GetUserRankInRoomAsync(long roomId, int userId) | |||
| var connection = await getConnectionAsync(); | |||
|
|
|||
| return await connection.QuerySingleAsync<int>( | |||
| "SELECT COUNT(1) + 1 FROM `multiplayer_rooms_high` WHERE `room_id` = @roomId AND `user_id` != @userId " | |||
| + "AND `total_score` > (SELECT `total_score` FROM `multiplayer_rooms_high` WHERE `room_id` = @roomId AND `user_id` = @userId)", | |||
| "WITH `user_score` AS (SELECT `total_score`, `last_score_id` FROM `multiplayer_rooms_high` WHERE `room_id` = @roomId AND `user_id` = @userId) " | |||
There was a problem hiding this comment.
I've never used this style of sql before, but have confirmed it works well and I have no prettier ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should match web, in theory.
Not sure about the CTE usage but it's one row and I'd rather try this than duplicate the subquery.