Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching and total room score tracking for multiplayer playlist item statistics #242

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Add caching and total room score tracking for multiplayer playlist item statistics #242

merged 15 commits into from
Jul 26, 2024

Commits on Jul 26, 2024

  1. Remove unused IDistributedCache for now

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9fb0634 View commit details
    Browse the repository at this point in the history

  2. Populate TotalPlaylistScore

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    2c9a225 View commit details
    Browse the repository at this point in the history

  3. Update structure of multiplayer stats to support caching 

    Note that this doesn't actually perform caching yet. Nor does it have
the more complex part of updating each item's distribution.

One step at a time.
    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3910713 View commit details
    Browse the repository at this point in the history

  4. Add support for updating existing distributions

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6a6d720 View commit details
    Browse the repository at this point in the history

  5. Use explicit types

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    bf0a1e7 View commit details
    Browse the repository at this point in the history

  6. Cache multiplayer room stats to a MemoryCache

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b33c60c View commit details
    Browse the repository at this point in the history

  7. Move update implementation out of IDatabaseAccess and add locking

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f5eca42 View commit details
    Browse the repository at this point in the history

  8. Add expiry for caching

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3f9aff3 View commit details
    Browse the repository at this point in the history

  9. Add missing memory cache registration

    @bdach
    bdach committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0749e3c View commit details
    Browse the repository at this point in the history

  10. Skip multiplayer room stats update if no scores returned since last time 

    The reason for doing this is mainly that the `LastProcessedScoreID`
update at the end of the method would crash (`.Max()` doesn't like empty
sequences), but being able to skip the lock contention is also very
nice.
    @bdach
    bdach committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7703def View commit details
    Browse the repository at this point in the history

  11. Update naming in line with model

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1a2ff75 View commit details
    Browse the repository at this point in the history

  12. Update osu.Game

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7e29215 View commit details
    Browse the repository at this point in the history

  13. Apply cleanup review

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    bd9e6b4 View commit details
    Browse the repository at this point in the history

  14. Cache stats for slightly longer

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e81021d View commit details
    Browse the repository at this point in the history

  15. Fix potential double-counting of scores

    @peppy
    peppy committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    40db2ed View commit details
    Browse the repository at this point in the history