Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --large-tick-misses and --slider-tail-misses parameters to simulate command #225

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Add --large-tick-misses and --slider-tail-misses parameters to simulate command #225

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f57c820
Add slider tail hits and large tick misses
minisbett Oct 18, 2024
5454df4
Add large tick misses and slider tail misses parameter
minisbett Oct 18, 2024
5e4e495
Merge branch 'simulate-parameter-handling' into large-tick-misses-par…
minisbett Oct 18, 2024
e11e23a
code quality
minisbett Oct 19, 2024
e235ae9
Merge branch 'master' into large-tick-misses-parameter
smoogipoo Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions PerformanceCalculator/Simulate/OsuSimulateCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,13 @@

using System;
using System.Collections.Generic;
using System.Linq;
using JetBrains.Annotations;
using McMaster.Extensions.CommandLineUtils;
using osu.Game.Beatmaps;
using osu.Game.Rulesets;
using osu.Game.Rulesets.Osu;
using osu.Game.Rulesets.Osu.Objects;
using osu.Game.Rulesets.Scoring;

namespace PerformanceCalculator.Simulate
Expand All @@ -31,6 +33,14 @@ public class OsuSimulateCommand : SimulateCommand
[Option(Template = "-C|--percent-combo <combo>", Description = "Percentage of beatmap maximum combo achieved. Alternative to combo option. Enter as decimal 0-100.")]
public override double PercentCombo { get; } = 100;

[UsedImplicitly]
[Option(Template = "-L|--large-tick-misses <misses>", Description = "Number of large tick misses. Defaults to 0.")]
private int largeTickMisses { get; }

[UsedImplicitly]
[Option(Template = "-S|--slider-tail-misses <misses>", Description = "Number of slider tail misses. Defaults to 0.")]
private int sliderTailMisses { get; }

public override Ruleset Ruleset => new OsuRuleset();

protected override int GetMaxCombo(IBeatmap beatmap) => beatmap.GetMaxCombo();
Expand Down Expand Up @@ -116,6 +126,8 @@ protected override Dictionary<HitResult, int> GenerateHitResults(double accuracy
{ HitResult.Great, countGreat },
{ HitResult.Ok, countGood ?? 0 },
{ HitResult.Meh, countMeh ?? 0 },
{ HitResult.LargeTickMiss, largeTickMisses },
{ HitResult.SliderTailHit, beatmap.HitObjects.Count(x => x is Slider) - sliderTailMisses },
{ HitResult.Miss, countMiss }
};
}
Expand Down
Loading