Handle null icon_id case

ppy · Jun 17, 2024 · 2d90599 · 2d90599
1 parent c0a70b9
commit 2d90599
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/app/Models/Forum/Post.php b/app/Models/Forum/Post.php
@@ -397,6 +397,13 @@ public function isBeatmapsetPost()
 
     public function legacyIcon(): ?LegacyIcon
     {
+        // TODO: $this->icon_id shouldn't be null, but there are some cases
+        // where we make a new Post model and don't refresh it with the default
+        // attributes from database
+        if ($this->icon_id === null) {
+            return null;
+        }
+
         return app('forum-legacy-icons')->byId($this->icon_id);
     }