Include user score position when indexing playlist item scores #11354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Jul 24, 2024
| ScoreTransformer::MULTIPLAYER_BASE_INCLUDES | ||
| [ | ||
| ...ScoreTransformer::MULTIPLAYER_BASE_INCLUDES, | ||
| 'position', |
There was a problem hiding this comment.
I can maybe skip this one and hardcode a 1..50 position client-side if it helps. (Does mean we would require a client deploy for daily challenge to go live though.)
There was a problem hiding this comment.
yeah this will cause as many additional queries as there are scores
There was a problem hiding this comment.
Have force-pushed this out.
ppy/osu#29036 would be the client-side solution.
Needed for daily challenge (without this client can't show position numbers for the user score on the leaderboard).
bdach
force-pushed
the
multiplayer-include-position
branch
from
0ec9c56
to
d77b27b
Compare
bdach
changed the title
bdach
added a commit
to bdach/osu
that referenced
this pull request
Jul 24, 2024
Only doing this client-side, because doing this server-side is expensive: ppy/osu-web#11354 (comment)
nanaya
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for daily challenge (without this client can't show position numbers for the user score on the leaderboard).
A second review for performance implications is probably best-advised, this monkey just fix no number showing with hammer. I tried to ask once but got no reply.