Merge pull request #29711 from smoogipoo/add-played-acronyms

Add 'yes'/'no' acronyms to the `played=` filter
ppy · Sep 6, 2024 · 04d1338 · 04d1338
2 parents a912d86 + 6913d75
commit 04d1338
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs b/osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs
@@ -633,11 +633,15 @@ public void TestOutOfRangeDateQuery()
  new object[] { "0", DateTimeOffset.Now, false },
  new object[] { "false", DateTimeOffset.MinValue, true },
  new object[] { "false", DateTimeOffset.Now, false },
+ new object[] { "no", DateTimeOffset.MinValue, true },
+ new object[] { "no", DateTimeOffset.Now, false },
 
  new object[] { "1", DateTimeOffset.MinValue, false },
  new object[] { "1", DateTimeOffset.Now, true },
  new object[] { "true", DateTimeOffset.MinValue, false },
  new object[] { "true", DateTimeOffset.Now, true },
+ new object[] { "yes", DateTimeOffset.MinValue, false },
+ new object[] { "yes", DateTimeOffset.Now, true },
  };
 
  [Test]

diff --git a/osu.Game/Screens/Select/FilterQueryParser.cs b/osu.Game/Screens/Select/FilterQueryParser.cs
@@ -159,10 +159,12 @@ private static bool tryParseBool(string value, out bool result)
  switch (value)
  {
  case "1":
+ case "yes":
  result = true;
  return true;
 
  case "0":
+ case "no":
  result = false;
  return true;