Skip to content

Commit

Permalink
Merge branch 'frame-stable-cache' into skin/argon-song-progress-cleaner
Browse files Browse the repository at this point in the history
  • Loading branch information
peppy committed Jan 18, 2023
2 parents 67b40dd + 0470550 commit 4cfb059
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion osu.Game/Screens/Play/Player.cs
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ private void load(AudioManager audio, OsuConfigManager config, OsuGameBase game,

DrawableRuleset = ruleset.CreateDrawableRulesetWith(playableBeatmap, gameplayMods);
dependencies.CacheAs(DrawableRuleset);
dependencies.CacheAs(DrawableRuleset.FrameStableClock);

ScoreProcessor = ruleset.CreateScoreProcessor();
ScoreProcessor.Mods.Value = gameplayMods;
Expand Down Expand Up @@ -310,6 +309,8 @@ private void load(AudioManager audio, OsuConfigManager config, OsuGameBase game,
});
}

dependencies.CacheAs(DrawableRuleset.FrameStableClock);

// add the overlay components as a separate step as they proxy some elements from the above underlay/gameplay components.
// also give the overlays the ruleset skin provider to allow rulesets to potentially override HUD elements (used to disable combo counters etc.)
// we may want to limit this in the future to disallow rulesets from outright replacing elements the user expects to be there.
Expand Down

0 comments on commit 4cfb059

Please sign in to comment.