Merge pull request #24547 from bdach/slider-kiai-stars-broke

Fix kiai stars flickering on and off during gameplay
ppy · Aug 15, 2023 · 57e4949 · 57e4949
2 parents 31c31a9 + ab1d523
commit 57e4949
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/osu.Game/Graphics/ParticleSpewer.cs b/osu.Game/Graphics/ParticleSpewer.cs
@@ -49,19 +49,27 @@ protected ParticleSpewer(Texture texture, int perSecond, double maxDuration)
             this.maxDuration = maxDuration;
         }
 
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
+
+            Active.BindValueChanged(active =>
+            {
+                // ensure that particles can be spawned immediately after the spewer becomes active.
+                if (active.NewValue)
+                    lastParticleAdded = null;
+            });
+        }
+
         protected override void Update()
         {
             base.Update();
 
             Invalidate(Invalidation.DrawNode);
 
             if (!Active.Value || !CanSpawnParticles)
-            {
-                lastParticleAdded = null;
                 return;
-            }
 
-            // Always want to spawn the first particle in an activation immediately.
             if (lastParticleAdded == null)
             {
                 lastParticleAdded = Time.Current;