Add note explaining shadow opacity

pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`
ppy · Feb 13, 2023 · be52d0a · be52d0a
1 parent 61584ba
commit be52d0a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs b/osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs
@@ -36,8 +36,8 @@ public partial class FooterButtonV2 : OsuClickableContainer, IKeyBindingHandler<
 
         protected static readonly Vector2 SHEAR = new Vector2(SHEAR_WIDTH / button_height, 0);
 
-        [Cached]
-        private OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Aquamarine);
+        [Resolved]
+        private OverlayColourProvider colourProvider { get; set; } = null!;
 
         private Colour4 buttonAccentColour;
 
@@ -74,7 +74,8 @@ public FooterButtonV2()
             {
                 Type = EdgeEffectType.Shadow,
                 Radius = 5,
-                Colour = Colour4.Black.Opacity(0.5f)
+                // Figma says 50% opacity, but it does not match up visually if taken at face value, and looks bad.
+                Colour = Colour4.Black.Opacity(0.25f)
             };
             Shear = SHEAR;
             Size = new Vector2(button_width, button_height);