Merge pull request #29695 from peppy/fail-t-request-on-null-response

Trigger request failure on receiving a null response for a typed `APIRequest`
ppy · Sep 5, 2024 · c51503c · c51503c
2 parents 3a3a912 + 6fc6090
commit c51503c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/osu.Game/Online/API/APIRequest.cs b/osu.Game/Online/API/APIRequest.cs
@@ -46,6 +46,9 @@ protected override void PostProcess()
                 Response = ((OsuJsonWebRequest<T>)WebRequest).ResponseObject;
                 Logger.Log($"{GetType().ReadableName()} finished with response size of {WebRequest.ResponseStream.Length:#,0} bytes", LoggingTarget.Network);
             }
+
+            if (Response == null)
+                TriggerFailure(new ArgumentNullException(nameof(Response)));
         }
 
         internal void TriggerSuccess(T result)
@@ -152,6 +155,8 @@ public void Perform()
 
             PostProcess();
 
+            if (isFailing) return;
+
             TriggerSuccess();
         }