Change default masking value to true

ppy · Jan 21, 2024 · e003ecb · e003ecb
1 parent 6ba3546
commit e003ecb
Show file tree

Hide file tree

Showing 11 changed files with 7 additions and 10 deletions.
diff --git a/osu.Game.Rulesets.Osu/Skinning/Default/TrianglesPiece.cs b/osu.Game.Rulesets.Osu/Skinning/Default/TrianglesPiece.cs
@@ -15,6 +15,7 @@ public TrianglesPiece(int? seed = null)
         {
             TriangleScale = 1.2f;
             HideAlphaDiscrepancies = false;
+            Masking = false;
         }
 
         protected override void Update()

diff --git a/osu.Game/Graphics/Backgrounds/Triangles.cs b/osu.Game/Graphics/Backgrounds/Triangles.cs
@@ -78,9 +78,9 @@ public float TriangleScale
 
         /// <summary>
         /// If enabled, only the portion of triangles that falls within this <see cref="Drawable"/>'s
-        /// shape is drawn to the screen.
+        /// shape is drawn to the screen. Default is true.
         /// </summary>
-        public bool Masking { get; set; }
+        public bool Masking { get; set; } = true;
 
         /// <summary>
         /// Whether we should drop-off alpha values of triangles more quickly to improve

diff --git a/osu.Game/Graphics/Backgrounds/TrianglesV2.cs b/osu.Game/Graphics/Backgrounds/TrianglesV2.cs
@@ -34,9 +34,9 @@ public partial class TrianglesV2 : Drawable
 
         /// <summary>
         /// If enabled, only the portion of triangles that falls within this <see cref="Drawable"/>'s
-        /// shape is drawn to the screen.
+        /// shape is drawn to the screen. Default is true.
         /// </summary>
-        public bool Masking { get; set; }
+        public bool Masking { get; set; } = true;
 
         private readonly BindableFloat spawnRatio = new BindableFloat(1f);
 

diff --git a/osu.Game/Graphics/UserInterface/DialogButton.cs b/osu.Game/Graphics/UserInterface/DialogButton.cs
@@ -150,6 +150,7 @@ public DialogButton(HoverSampleSet sampleSet = HoverSampleSet.Button)
                                             TriangleScale = 4,
                                             ColourDark = OsuColour.Gray(0.88f),
                                             Shear = new Vector2(-0.2f, 0),
+                                            Masking = false
                                         },
                                     },
                                 },

diff --git a/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs b/osu.Game/Graphics/UserInterfaceV2/RoundedButton.cs
@@ -68,7 +68,6 @@ protected override void LoadComplete()
                 SpawnRatio = 0.6f,
                 RelativeSizeAxes = Axes.Both,
                 Depth = float.MaxValue,
-                Masking = true
             });
 
             updateColours();

diff --git a/osu.Game/Online/Leaderboards/DrawableRank.cs b/osu.Game/Online/Leaderboards/DrawableRank.cs
@@ -50,7 +50,6 @@ public DrawableRank(ScoreRank rank)
                             ColourDark = rankColour.Darken(0.1f),
                             ColourLight = rankColour.Lighten(0.1f),
                             Velocity = 0.25f,
-                            Masking = true
                         },
                         new OsuSpriteText
                         {

diff --git a/osu.Game/Overlays/Dialog/PopupDialog.cs b/osu.Game/Overlays/Dialog/PopupDialog.cs
@@ -150,7 +150,6 @@ protected PopupDialog()
                                     ColourLight = Color4Extensions.FromHex(@"271e26"),
                                     ColourDark = Color4Extensions.FromHex(@"1e171e"),
                                     TriangleScale = 4,
-                                    Masking = true
                                 },
                                 flashLayer = new Box
                                 {

diff --git a/osu.Game/Overlays/Mods/ModSelectColumn.cs b/osu.Game/Overlays/Mods/ModSelectColumn.cs
@@ -95,6 +95,7 @@ protected ModSelectColumn()
                                     Height = header_height,
                                     Shear = new Vector2(-ShearedOverlayContainer.SHEAR, 0),
                                     Velocity = 0.7f,
+                                    Masking = false
                                 },
                                 headerText = new OsuTextFlowContainer(t =>
                                 {

diff --git a/osu.Game/Overlays/Toolbar/ToolbarButton.cs b/osu.Game/Overlays/Toolbar/ToolbarButton.cs
@@ -255,7 +255,6 @@ public OpaqueBackground()
                     RelativeSizeAxes = Axes.Both,
                     ColourLight = OsuColour.Gray(40),
                     ColourDark = OsuColour.Gray(20),
-                    Masking = true
                 },
             };
         }

diff --git a/osu.Game/Screens/Menu/OsuLogo.cs b/osu.Game/Screens/Menu/OsuLogo.cs
@@ -192,7 +192,6 @@ public OsuLogo()
                                                                             ColourLight = Color4Extensions.FromHex(@"ff7db7"),
                                                                             ColourDark = Color4Extensions.FromHex(@"de5b95"),
                                                                             RelativeSizeAxes = Axes.Both,
-                                                                            Masking = true
                                                                         },
                                                                     }
                                                                 },

diff --git a/osu.Game/Screens/Select/Carousel/DrawableCarouselBeatmap.cs b/osu.Game/Screens/Select/Carousel/DrawableCarouselBeatmap.cs
@@ -110,7 +110,6 @@ private void load(BeatmapManager? manager, SongSelect? songSelect)
                     RelativeSizeAxes = Axes.Both,
                     ColourLight = Color4Extensions.FromHex(@"3a7285"),
                     ColourDark = Color4Extensions.FromHex(@"123744"),
-                    Masking = true
                 },
                 new FillFlowContainer
                 {